Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockly #257

Closed
wants to merge 2 commits into from
Closed

Blockly #257

wants to merge 2 commits into from

Conversation

vorburger
Copy link
Contributor

Hello @walterhiggins, here is finally the PR for the Blockly stuff! Do you like? Will merge? Best, M.

vorburger and others added 2 commits May 30, 2015 00:32
@vorburger
Base blockly(Mine)Craft for ScriptCraft! Includes:
23e54ba 
* integrated Web Server; incl. POST support
* build script fetches get Blockly and jQuery
* working basic minimal *.js copied from Lauro's ZIP
* re-disabled httpServer.openURL(), because with refresh() its PITA :(
* .gitignore for files which should not be under source control
* clean-up up, minor reformatting, fixed a typo
* README blurb & Help TODO reminder
@laurocanonica @vorburger
Blockly(Mine)Craft clean-up, and multi-lang. translation support
1f52176 
added multilanguage support for materials
added multilanguage to animals and ocmmands
fixed indentation of generated javascript
removed dependency from third party messages
Added the warning messages to the translation mechanism
renamed files, reorganized functions, added info in the README.txt
added language files for minecraft messages
@walterhiggins
Copy link
Owner

Hi @vorburger ,
This is a significantly large pull request which includes source code from other Open source modules. My gut feeling is this should probably be in it's own repository/project separate from ScriptCraft.
I'm uncomfortable with the idea of including the nanohttpd source code and devoxx source code here.
If you want to maintain a separate project/repo for this, that would be good. I just don't think this should be part of scriptcraft's source repo.

Walter

@TechplexEngineer
Copy link

Is this what LearnToMod is based on?

@djMax
Copy link

djMax commented Dec 17, 2016

I had built something along these lines as a standalone server and then have a simple command in ScriptCraft to just fetch the code from the server and eval it. Now of course that's a bit dangerous, but since it's done at the behest of the user, I felt like it wasn't so bad. But importantly, it would mean little to no changes to the ScriptCraft code to support this. I do think this is a super important step in using this for certain age groups. The current "REPL" is just too brittle for new users.

@walterhiggins
Copy link
Owner

Closing PR as it is 4 years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vorburger @walterhiggins @TechplexEngineer @djMax @laurocanonica