You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @w8r, thanks for your work on splay-tree. Very helpful lib.
Per the docs in the README, remove() is intended to return a boolean. Per the docs in remove()'s docstring, it should return a node or null. However, it just returns undefined, irrespective of whether it removed anything or not from the tree.
Note that it appears this is addressed by an open PR: #5
The text was updated successfully, but these errors were encountered:
Hi @w8r, thanks for your work on splay-tree. Very helpful lib.
Per the docs in the README,
remove()
is intended to return a boolean. Per the docs in remove()'s docstring, it should return a node ornull
. However, it just returnsundefined
, irrespective of whether it removed anything or not from the tree.Note that it appears this is addressed by an open PR: #5
The text was updated successfully, but these errors were encountered: