Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove() always returns undefined #7

Open
mfogel opened this issue Nov 18, 2018 · 0 comments
Open

remove() always returns undefined #7

mfogel opened this issue Nov 18, 2018 · 0 comments

Comments

@mfogel
Copy link

mfogel commented Nov 18, 2018

Hi @w8r, thanks for your work on splay-tree. Very helpful lib.

Per the docs in the README, remove() is intended to return a boolean. Per the docs in remove()'s docstring, it should return a node or null. However, it just returns undefined, irrespective of whether it removed anything or not from the tree.

Note that it appears this is addressed by an open PR: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant