Change type of credProps.authenticatorDisplayName to DOMString #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended by the Web IDL spec [1]: >Specifications should only use `USVString` for APIs that perform text >processing and need a string of scalar values to operate on. Most APIs that use >strings should instead be using `DOMString`, which does not make any >interpretations of the code units in the string. When in doubt, use `DOMString`. [1]: https://webidl.spec.whatwg.org/#idl-USVString
MasterKale
approved these changes
Aug 7, 2024
agl
approved these changes
Aug 14, 2024
pascoej
approved these changes
Aug 14, 2024
timcappalli
approved these changes
Aug 14, 2024
|
Top comment updated with links to bug trackers. |
github-actions bot
added a commit
that referenced
this pull request
Aug 28, 2024
SHA: 6a79516 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by the Web IDL spec:
Implementation commitment:
Documentation and checks
[ ] Pinged MDNcredProps.authenticatorDisplayNamenot yet documented on MDN: WebAuthn ExtensionsPreview | Diff