Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles optional/loaded after vuepress styles #10

Closed
travispamaral opened this issue Jun 20, 2019 · 8 comments · Fixed by #11
Closed

Styles optional/loaded after vuepress styles #10

travispamaral opened this issue Jun 20, 2019 · 8 comments · Fixed by #11
Labels
question Further information is requested released

Comments

@travispamaral
Copy link

Hi there! I just started using this and Im quickly finding I don't really need these defined styles. Im not sure how Vuepress plugins work but is there anyway to allow these to be optional or more easy to overwrite/remove? Adding !important to every declaration seems like a lot.

https://github.com/vue-styleguidist/vuepress-plugin-live/blob/master/layout.vue#L12

Thanks! Great work 👍🏼

@flozero
Copy link
Member

flozero commented Jun 20, 2019

Hello thank's for using it :)

Do you have a repo to try it ?

@flozero flozero added the question Further information is requested label Jun 21, 2019
@elevatebart
Copy link
Member

Hey @travispamaral

Thank you for your interest in the plugin.
We could add an option to load the layout component yourself.
Would that solve your issue?

@elevatebart
Copy link
Member

@f3ltron
In this file I would change the layout to become an optional prop of the component and change enhanceAppFiles.js to specify where to find the layout if provided.

@travispamaral
Copy link
Author

@f3ltron I unfortunately am implementing in a private repo so I cannot share.

@elevatebart that would be a great addition! I think having the ability to choose whether or not users can implement their own layout/styles or use the default would be a huge help.

@flozero
Copy link
Member

flozero commented Jun 22, 2019

ok @elevatebart i could propore something for that.

Maybe they just want to update a part of the css now ?

@elevatebart
Copy link
Member

@travispamaral I delivered the feature, I hope you like it ;)

@elevatebart
Copy link
Member

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@travispamaral
Copy link
Author

@elevatebart you rock! Thanks so much, I was going to try and PR the change over the weekend but couldn't get to it. Thanks again 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants