varikn fails to install in fedora:40 docker

[thfrkielikone]

Hi,
I am trying to install varikn in a Fedora 40 docker container with python 3.12.3 and pip 23.3.2. Pip complains that certain information ("description", "authors", "license", "readme") is being sourced from outside the pyproject.toml and doesn't want to install (either through pip install . in the cloned repo or through the prebuilt package) it unless the source of that information is either moved to the pyproject.toml or marked as dynamic. Marking it as dynamic can seemingly be done per the patch below, which seems to be the easiest way to fix this (then it installs without complaint at least through pip install .). Can you reproduce this issue and would this be a reasonable fix?

diff --git a/pyproject.toml b/pyproject.toml
index b6f24b0..6547a30 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -8,7 +8,8 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "varikn"
-dynamic = ["version"]
+dynamic = ["version", "description", "authors", "license", "readme"]
+
 
 [tool.setuptools_scm]
 write_to = "python-wrapper/varikn/_version.py"

[vsiivola]

The patch looks good to me, I'll try it this weekend and merge if there are no problems. Thanks!

[vsiivola]

It is in master, I hope it works now.

[vsiivola]

@svirpioj Should we do a version release to PYPI?

[thfrkielikone]

Thank you very much for looking into this this quickly!

[vsiivola]

I tagged version 1.2.1, let's see if the GitHub action for PYPI update still works 🤞

[vsiivola]

Ok 1.2.1 is in PYPI, but doing source install from PYPI requires that cmake and swig are first installed manually. I wonder if that's how it always worked or if something broke...

[vsiivola]

Looking at INSTALL.md I guess that's how it has always been.

[svirpioj]

Yeah, probably so. Seems everything is in order 🙂