-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: what to do about Numpy 2.0.0 final #298
Comments
fixed by removing scikit-image as a dependency in lick 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here's what we know about recent and upcoming events in the ecosystem
<2.0
As a result, when 2.0.0 final comes out, installing nonos in a new env will by default install
numpy 2.0
unless something else in our dependency tree pins it. This is not a problem if everything in our dependency tree is already compatible at that point, but it might not be the case:I see in particular that the first version of
scikit-image
(which we depend on vialick
) with numpy 2 compat will not support Python 3.9, while numpy 2.0 supports it. I'd conclude thatpip install nonos
in a new env might create a broken env on Python 3.9, which will be visible if anyone tries to useNonosLick
in these conditions.The easiest solution on our side would be to drop support for 3.8 and 3.9 but it's a very aggressive move. We could also mitigate the issue by pinning
numpy<2 ; python_version < '3.10'
, but should it be done innonos
or inlick
, who's the one bringing the problematic dependency ?Here's a tracker issue to see the whole ecosystem moving towards numpy 2
numpy/numpy#26191
The text was updated successfully, but these errors were encountered: