Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with gRPC 1.51 fails #676

Open
cpaelzer opened this issue Jul 11, 2023 · 1 comment
Open

Build with gRPC 1.51 fails #676

cpaelzer opened this issue Jul 11, 2023 · 1 comment
Labels

Comments

@cpaelzer
Copy link

Describe the bug

Build in Debian started to fail with newer gRPC and was reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025491

Here is a full Debian build log with the fail retrying against the most recent 12.2.5
open-vm-tools-failing-grpc1.51.txt

Reproduction steps

  1. install current libgrpc-dev 1.51.1-3+b2
  2. install all other build dependencies
  3. Build open-vm-tools

Expected behavior

Build correctly even with the new gRPC

Additional context

There was a fix proposed in the Debian bug which fixes the build.
You might have a look at that at https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=1025491;filename=open-vm-tools_grpc.patch;msg=5

@cpaelzer cpaelzer added the bug label Jul 11, 2023
@johnwvmw
Copy link
Contributor

@cpaelzer

Actually VMware recently resync'ed our internal open-vm-tools test builds to use the latest Debian / Ubuntu open-vm-tools build source. The patch patches/debian/grpc_1.51 was in that source tree.

We have integrated the pull request #664 with the slight change in configure.ac as shown in comment response. With that modified pull request integrated, we are internally building and testing without the "grpc_1.51" patch for:

Ubuntu 23.04 (lunar) with libgrpc++1.51/lunar,now 1.51.1-3build3 amd64 [installed,automatic]
Debian 12 (bookworm) with libgrpc++1.51/stable,stable,now 1.51.1-3+b1 amd64 [installed,automatic]

The pull request is in the upcoming open-vm-tools 12.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants