Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to make sure all our condition types/statuses/reasons are defined in the appropriate API package. #615

Open
mattmoyer opened this issue May 12, 2021 · 1 comment
Open

Refactor to make sure all our condition types/statuses/reasons are defined in the appropriate API package. #615

mattmoyer opened this issue May 12, 2021 · 1 comment
Labels
chore Not a bug or an enhancement, but still a work item good first issue Good for newcomers priority/undecided Not yet prioritized

Comments

@mattmoyer
Copy link
Contributor

mattmoyer commented May 12, 2021 •
edited
Loading

We have some controllers such as the Supervisor "upstream watcher" controllers that defined condition "reason" codes. These are effectively part of our public API. We should make sure that all these constants are exported from some API package so that anyone importing our API definitions can reliably interact with these fields.

We could also do the same for the Supervisor header names and parameter values related to password logins.
@mattmoyer mattmoyer added the chore Not a bug or an enhancement, but still a work item label May 12, 2021
@cfryanr cfryanr mentioned this issue May 12, 2021
Merged
@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/undecided Not yet prioritized chore Not a bug or an enhancement, but still a work item and removed chore Not a bug or an enhancement, but still a work item enhancement New feature or request labels May 12, 2021
@anjaltelang anjaltelang added the good first issue Good for newcomers label Dec 7, 2021
@anjaltelang
Copy link
Contributor

Reviewed on 12-7-21. Seems to be a good first issue for contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Not a bug or an enhancement, but still a work item good first issue Good for newcomers priority/undecided Not yet prioritized
Projects
Pinniped roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattmoyer @anjaltelang @pinniped-ci-bot