Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for windows 10/11 enterprise #688

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat: add support for windows 10/11 enterprise #688

merged 1 commit into from
Sep 22, 2023

Conversation

rcroft-work
Copy link
Contributor

@rcroft-work rcroft-work commented Sep 22, 2023 •
edited by tenthirtyam
Loading

Summary of Pull Request

  • Adds Windows 11 Enterprise to the project.
  • Adds Windows 10 Enterprise to the project.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Resolves #687

Issue Number: #687

Test and Documentation Coverage

  • Tests have been completed only internal environment
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@rcroft-work rcroft-work requested a review from a team as a code owner September 22, 2023 03:17
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Sep 22, 2023
@rcroft-work rcroft-work changed the title Feat: Add Windows 10/11 Enterprise support feat: Add Windows 10/11 Enterprise support Sep 22, 2023
tenthirtyam
tenthirtyam previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam added this to the .Next milestone Sep 22, 2023
@tenthirtyam tenthirtyam added the status/planned Planned label Sep 22, 2023
@tenthirtyam tenthirtyam changed the title feat: Add Windows 10/11 Enterprise support feat: add support for windows 10/11 enterprise Sep 22, 2023
@tenthirtyam tenthirtyam merged commit f1d7bf4 into vmware-samples:develop Sep 22, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam left review comments

@GaryJBlake GaryJBlake Awaiting requested review from GaryJBlake GaryJBlake is a code owner automatically assigned from vmware-samples/packer-examples-for-vsphere-maintainers

Assignees

@rcroft-work rcroft-work

Labels
cla-not-required Contributor License Agreement Not Required status/planned Planned
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Add Windows 10/11 Enterprise support
3 participants
@rcroft-work @tenthirtyam @vmwclabot