-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oracle linux #670
feat: add oracle linux #670
Conversation
@virtualistic, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
@virtualistic, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build.yaml needs to be updated. This is used to generated the build.sh with gomplate.
The README.md would also need an update.
Marked as drafted until the CLA is approved. |
I added a new commit which added Oracle Linux as an entry to the README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @virtualistic -
Please run the following to generate the build.sh
:
gomplate -c build.yaml -f build.tmpl -o build.sh
Additionally, in the README.md
and update is needed to list the download information for each the distribution:
Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.
Created a new commit that:
|
Thanks! Once the CLA is approved I'll run the standard tests. I have a couple updates and pull requests that I have in my backlog for this side project but will prioritize as soon as possible. Might I ask you to open an enhancement issue and link the pull request with "Closes #x" when time permits. |
Sure, no problem. ( Enhancement request has a typo btw: "Please add a short decsription." ) |
Closes is put here in the PR back to the enhancement issue. thanks for the note on the issue form! :) |
closes #671 |
Most welcome!
|
Please use the original file name from the vendor and an oel or oracle path. |
@virtualistic, VMware has approved your signed contributor license agreement. |
5cb8666
to
137d3c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes.
Would you consider adding OEL 9?
I agree with your suggested changes. Think it's best I edit my repo and create a new commit with the changes? |
"signoff and commit suggestion" is fine, but I generally just amend the last commit and force push. |
d77bf3b
to
267607f
Compare
Use |
…o match vendor name
267607f
to
9485cae
Compare
Ok, I changed all the requested files and did a :
Will have look if it's easy to add Oracle 9 now using my own Oracle 8 files 😄 |
Awesome! thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update `CHANGELOG.md` Signed-off-by: Ryan Johnson <[email protected]>
Signed-off-by: Ryan Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary of Pull Request
As I requested here:
#659 and inspired by your suggestion, created a new build for Oracle Linux 8. Had to change the menu a bit to "make room" for the Oracle 8 template at position 19. (I skipped position 18 for Oracle 9 in the future). I was able to successfully build a new Oracle 8 template but hopefully you have some time to test and verify this.
Type of Pull Request
type/bug
type/feature
ortype/enhancement
type/docs
type/refactor
type/chore
Please describe:
Related to Existing Issues
Closes #671
Test and Documentation Coverage
Breaking Changes?