fix: update vm_cpu_sockets to vm_cpu_count for CPUs
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `vm_cpu_sockets` to `vm_cpu_count` for CPUs. The project currently uses the variable `vm_cpu_sockets` for CPUs (see below); however, the value of the sockets is determined by dividing the number of CPUs by the number of cores per socket. #252 Signed-off-by: Ryan Johnson <[email protected]>
Updates `vm_cpu_sockets` to `vm_cpu_count` for CPUs. The project currently uses the variable `vm_cpu_sockets` for CPUs (see below); however, the value of the sockets is determined by dividing the number of CPUs by the number of cores per socket. #252 Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
added a commit
that referenced
this pull request
Aug 23, 2022
Updates `CHANGELOG.md` to include the breaking changes in #253. Signed-off-by: Ryan Johnson <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Updates
vm_cpu_socketstovm_cpu_countfor CPUs. The project currently uses the variablevm_cpu_socketsfor CPUs (see below); however, the value of the sockets is determined by dividing the number of CPUs by the number of cores per socket.Signed-off-by: Ryan Johnson [email protected]
Type of Pull Request
Please describe:
Related to Existing Issues
Closes: #252
Test and Documentation Coverage
Breaking Changes?