Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix or expr with non option fn call return #21661

Merged
merged 1 commit into from
Jun 10, 2024
Merged

cgen: fix or expr with non option fn call return #21661

merged 1 commit into from
Jun 10, 2024

Conversation

felipensp
Copy link
Member

Fix #21660

@felipensp felipensp marked this pull request as ready for review June 10, 2024 02:53
spytheman
spytheman approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit ef91808 into vlang:master Jun 10, 2024
76 checks passed
@felipensp felipensp deleted the fix_or_expr_with_non_opt branch June 10, 2024 13:22
raw-bin pushed a commit to raw-bin/v that referenced this pull request Jul 2, 2024
@felipensp @raw-bin
cgen: fix or expr with non option fn call return (fix vlang#21660) (v…
7c7c4aa 
…lang#21661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler bug when trying to return an interface-optional with a fallback default value
2 participants
@felipensp @spytheman