checker: fix return type of alias primitive operator overloading #21663

Delta456 · 2024-06-10T19:36:53Z

…n, cos }`

…ath { sin, cos }`" This reverts commit ddf0468.

Delta456 · 2024-06-11T17:27:10Z

I don't understand why https://github.com/vlang/v/actions/runs/9468240132/job/26089267012?pr=21663 is failing. The fail is unrelated to my changes.

vlib/v/tests/alias_primitive_operator_overloading_test.v

vlib/v/tests/alias_voidptr_operator_overloading_test.v

vlib/v/checker/infix.v

vlib/v/tests/alias_primitive_operator_overloading_test.v

medvednikov · 2024-06-12T17:55:23Z

vlib/v/checker/infix.v

@@ -435,7 +435,27 @@ fn (mut c Checker) infix_expr(mut node ast.InfixExpr) ast.Type {
 c.check_div_mod_by_zero(node.right, node.op)
 }

- return_type = promoted_type
+ left_sym = c.table.sym(unwrapped_left_type)


please add comments for such large code blocks to explain what they are for

ok! will add this in my next PR

…ases of primitive types (fix vlang#21654) (vlang#21663)

Delta456 added 3 commits June 11, 2024 01:08

checker: warn on unused imported functions used via `import math { si…

8b493e2

…n, cos }`

Revert "checker: warn on unused imported functions used via `import m…

0d1113c

…ath { sin, cos }`" This reverts commit ddf0468.

checker: fix return type of alias primitive operator overloading

97a10ac

Delta456 force-pushed the alias_return_type_accurate branch from 9601b43 to 97a10ac Compare June 10, 2024 19:38

Delta456 added 2 commits June 11, 2024 20:24

attempt to fix tests

53b788e

fix even more tests

cac4fdc

Delta456 marked this pull request as ready for review June 11, 2024 18:51

Delta456 requested a review from spytheman June 12, 2024 09:25