From 912adbeeba61196037fe66185a7c64396262f239 Mon Sep 17 00:00:00 2001 From: Chaejun Lee Date: Sat, 30 Dec 2023 00:46:34 -0800 Subject: [PATCH 1/2] fix: remove `context` from `render` --- playground/ssr-react/server.js | 8 +------- playground/ssr-react/src/entry-server.jsx | 4 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/playground/ssr-react/server.js b/playground/ssr-react/server.js index 7015917..385f9ba 100644 --- a/playground/ssr-react/server.js +++ b/playground/ssr-react/server.js @@ -73,13 +73,7 @@ export async function createServer( render = (await import('./dist/server/entry-server.js')).render } - const context = {} - const appHtml = render(url, context) - - if (context.url) { - // Somewhere a `` was rendered - return res.redirect(301, context.url) - } + const appHtml = render(url) const html = template.replace(``, appHtml) diff --git a/playground/ssr-react/src/entry-server.jsx b/playground/ssr-react/src/entry-server.jsx index 925fae6..e2d3436 100644 --- a/playground/ssr-react/src/entry-server.jsx +++ b/playground/ssr-react/src/entry-server.jsx @@ -2,9 +2,9 @@ import ReactDOMServer from 'react-dom/server' import { StaticRouter } from 'react-router-dom/server' import { App } from './App' -export function render(url, context) { +export function render(url) { return ReactDOMServer.renderToString( - + , ) From b6d7c5b38a22584dcfb8e8a5fb68acca87cb4903 Mon Sep 17 00:00:00 2001 From: Chaejun Lee Date: Sat, 30 Dec 2023 01:28:26 -0800 Subject: [PATCH 2/2] fix: remove `context` from `prerender.js` --- playground/ssr-react/prerender.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/playground/ssr-react/prerender.js b/playground/ssr-react/prerender.js index 8a18a49..fd4d1cc 100644 --- a/playground/ssr-react/prerender.js +++ b/playground/ssr-react/prerender.js @@ -22,8 +22,7 @@ const routesToPrerender = fs ;(async () => { // pre-render each route... for (const url of routesToPrerender) { - const context = {} - const appHtml = await render(url, context) + const appHtml = await render(url) const html = template.replace(``, appHtml)