Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make the y scale's min value dynamic in some cases #1565

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: Make the y scale's min value dynamic in some cases #1565

merged 2 commits into from
Jun 6, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 5, 2024 •
edited
Loading

Closes #1500

How to test

TEST

  1. Go to this link.
  2. Switch to a line chart.
  3. Open Vertical Axis menu.
  4. Change the measure to Anzahl geförderter EIV-Anlagen pro 100000 Einwohner (interval scale).
  5. Go to Horizontal Axis menu.
  6. Change the filtering so that it starts with 2016.
  7. ✅ See that the Y axis doesn't start at 0.

PROD

  1. Go to this link.
  2. Switch to a line chart.
  3. Open Vertical Axis menu.
  4. Change the measure to Anzahl geförderter EIV-Anlagen pro 100000 Einwohner (interval scale).
  5. Go to Horizontal Axis menu.
  6. Change the filtering so that it starts with 2016.
  7. ❌ See that the Y axis starts at 0.

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:15am

@bprusinowski bprusinowski merged commit bb597a9 into main Jun 6, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the feat/dynamic-y-scale-for-interval-measures branch June 6, 2024 13:44
@bprusinowski bprusinowski mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne Awaiting requested review from ptbrowne ptbrowne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For scaleType Interval - start y-Axis at lowest value (instead of 0)
2 participants
@bprusinowski @ptbrowne