Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Shapes4FREE icons #116

Closed
ajorg-aws opened this issue Sep 4, 2019 · 9 comments · Fixed by #145
Closed

Remove Shapes4FREE icons #116

ajorg-aws opened this issue Sep 4, 2019 · 9 comments · Fixed by #145
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@ajorg-aws
Copy link

The documentation uses external link icons from Shapes4FREE. The Shapes4FREE License is not an open source license (does not allow redistribution). There are comparable icons available from open source icon libraries. For example, Feather has a nice external link icon and an MIT License. Font Awesome also has some external link icons and a CC-BY-4.0 license for those, and there are likely other open source projects with similar icons. Alternatively, Unicode has the ↪ character, which is often used to denote external links, though it's not as familiar.

Would you consider replacing the Shapes4FREE icons with open source icons?

@mojoaxel mojoaxel added the bug Something isn't working label Sep 4, 2019
@mojoaxel
Copy link
Member

mojoaxel commented Sep 4, 2019

@ajorg-aws Thanks!
This has not been a problem for over 4 years now but I think we should replace these icons!

@mojoaxel mojoaxel added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 4, 2019
@r3code
Copy link
Contributor

r3code commented Sep 5, 2019

Related #31

@r3code
Copy link
Contributor

r3code commented Sep 5, 2019

@r3code
Copy link
Contributor

r3code commented Sep 5, 2019

<svg xmlns="https://www.w3.org/2000/svg" width="5" height="5" viewBox="0 0 24 24" fill="none" stroke="#000000" stroke-width="3" stroke-linecap="square" stroke-linejoin="arcs"><g fill="none" fill-rule="evenodd"><path d="M18 14v5a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8c0-1.1.9-2 2-2h5M15 3h6v6M10 14L20.2 3.8"/></g></svg>

img

@r3code
Copy link
Contributor

r3code commented Sep 10, 2019

@mojoaxel maybe we just remove them? I didn't find any reference in vis-network files.

@Thomaash
Copy link
Member

Hmm, I checked all of the projects and it doesn't seem to be used at all. We can probably remove it from all of them without any replacement.

@r3code do you plan to open PRs?

Occurrences:

  • vis-data/docs/img/external-link-icons
  • vis-graph3d/docs/img/external-link-icons
  • vis-network/docs/img/external-link-icons
  • vis-timeline/docs/img/external-link-icons

@Thomaash Thomaash changed the title Shapes4FREE License Remove Shapes4FREE icons Sep 13, 2019
@r3code
Copy link
Contributor

r3code commented Sep 16, 2019

@r3code do you plan to open PRs?

@Thomaash You propose me to delete them by myself for all the projects you have listed?

@Thomaash
Copy link
Member

If you want to you can. My motivation for opening these additional issues and not doing it myself was that this is a straightforward thing for first time contributors who don't have deep insight into the project but still want to contribute. You know something easy that anybody can do and then maybe work their way up to more complex contributions.

@vis-bot
Copy link
Collaborator

vis-bot commented Oct 24, 2019

🎉 This issue has been resolved in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants