Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplement detail about plane homography warping between src camera and tgt camera. #20

Open
SunshineWYC opened this issue Mar 7, 2022 · 2 comments

Comments

@SunshineWYC
Copy link

In operations/homography_sampler.py file,
1
Line 107-108 calculate plane homography warping matrix between src camera and tgt camera, following the equation:
2
While the K_inv should be K_tgt_inv, not the K_src_inv, K should be K_src. This issue will not happen when K_tgt=K_src, but cause error when intrinsics are not equal.
H_tgt_src = torch.matmul(K_src, torch.matmul(R_tnd, K_tgt_inv))

@conallwang
Copy link

Here, the author first computes homography matrix (H_tgt_src) that warps pixels in the source view to the target view and then inverse it ( line 113 in operations/homography_sampler.py ). So for this question, the release code is right.

@SunshineWYC
Copy link
Author

Thanks for apply, the inplement is right. I misunderstood this detail when firstly reading the code.
Sincerely,thanks very much for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants