Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK in KDE, Cinnamon. Title buttons have wrong icons. #284

Closed
evgeniy-harchenko opened this issue Mar 10, 2023 · 9 comments
Closed

GTK in KDE, Cinnamon. Title buttons have wrong icons. #284

evgeniy-harchenko opened this issue Mar 10, 2023 · 9 comments

Comments

@evgeniy-harchenko
Copy link
Contributor

evgeniy-harchenko commented Mar 10, 2023

I use this theme for GTK apps in KDE Plasma. All work good except title buttons. They use default Breeze textures. Examples of buggy apps: gedit, bleachbit, pamac, chromium(with gtk theme).
1
The problem apeared in version 2022-05-29 after commit 136f9f8.

Update: same with all apps in Cinnamon (tested on Manjaro and EndeavourOS). Theme uses strange (may be fallback) title button icons.
3

@evgeniy-harchenko evgeniy-harchenko changed the title GTK in KDE. Title buttons have wrong icons. GTK in KDE, Cinnamon. Title buttons have wrong icons. Mar 14, 2023
@Dejweed
Copy link
Contributor

Dejweed commented Mar 27, 2023

The title buttons follow the icon theme. Try changing the icon theme and see if there's a difference.

@evgeniy-harchenko
Copy link
Contributor Author

Yes, I forgot to mention that. There is normal icons in title buttons when I use Qogir-icon-theme. But I want to use other icons theme. Is there any possibility to built in icons in theme?

@Dejweed
Copy link
Contributor

Dejweed commented Apr 11, 2023

Looking at #232 it appears that built-in icons were removed to avoid bugs. The easiest thing for you would be to copy the window buttons from Qogir icon theme to your other icon theme. It isn't a perfect solution but it will get the job done. The icons you need are located at symbolic/actions.

  • window-minimize-symbolic
  • window-restore-symbolic
  • window-maximize-symbolic
  • window-close-symbolic

Go to your icon theme, find the directory with these icons and replace them.

I hope this is helpful :)

@evgeniy-harchenko
Copy link
Contributor Author

evgeniy-harchenko commented Apr 18, 2023

Yes it works, thanks! But is it normal that these apps have a bit smaller icons and red color of close button is pinky?
2
Top - Gimp, bottom - gedit.

@Dejweed
Copy link
Contributor

Dejweed commented Apr 18, 2023

Just tested it, it is normal, but it could be an oversight since the icons on Qogir-circle window themes aren't as big as they are on the square ones. And as for the colors, I think pinky is the intended one, but the red close button is also present in XFCE so I can't say for sure, but I think it should definitely be changed so they all look the same. I hope we can get a reply from @vinceliuice.
I've just made a fork, for now I only changed the normal theme (not light or dark), making the KDE version look more like GTK, let me know what you think.

@evgeniy-harchenko
Copy link
Contributor Author

Checked your variant. Yes, now GTK and KDE apps are almost the same. Top - gedit, bottom - konsole:
3
gedit close button is darker because its window is unfocused (close button in KDE apps does not fade when its on unfocused window). But as for me, bright red colour like in original theme looks better.

Also I tried to play with GTK theme on XFCE. Same thing. All apps look good, except gedit, bleachbit, pamac, chromium(with gtk theme). They have pinky close button and it becomes darker when its window is unfocused.

Finnaly I tried to use Metacity WM on XFCE. It makes all apps have pinky close buttons. So apps look almost the same with Metacity. Only excepted apps like gedit have darker close button when its window is unfocused.

@Dejweed
Copy link
Contributor

Dejweed commented Apr 19, 2023

If you want you can tweak the color to your liking. To make the close button red in apps like gedit, find the gtk-3.0/gtk.css or gtk-3.0/gtk-dark.css file and edit it. The lines you are looking for are headerbar button.titlebutton.close:hover and headerbar button.titlebutton.close:active. You can change the background-color to whatever you want. It looks like this:

headerbar button.titlebutton.close:hover, .titlebar button.titlebutton.close:hover {
background-color: #d7787d;
color: white;
}

headerbar button.titlebutton.close:active, .titlebar button.titlebutton.close:active {
background-color: #be3841;
color: white;
}

#d7787d is the pinky color and #be3841 is used when the button is pressed. You could also just replace every #d7787d with #ff5555 and #be3841 with #c83737, if that's what you want.
Note that the colors in Qogir-light are a bit different (#f68086 and #f13039).

So if you want to match it with the KDE theme it should look like this:

headerbar button.titlebutton.close:hover, .titlebar button.titlebutton.close:hover {
background-color: #ff5555;
color: white;
}

headerbar button.titlebutton.close:active, .titlebar button.titlebutton.close:active {
background-color: #c83737;
color: white;
}

I'm not sure about the inactive colors.

And if you want to change the red color in the KDE theme you need to edit aurorae/themes/Qogir/close.svg. Again just replace the colors with what you want.

This should give you what you want :)

@evgeniy-harchenko
Copy link
Contributor Author

Many thanks, I think we dealt with it.
12

Yes, sizes are a bit different. But it seems there is no point to change it because google-chrome has smaller buttons than KDE apps, while gedit has bigger.

I also created pull request with fix in Qogir-icon-theme.

@Dejweed
Copy link
Contributor

Dejweed commented May 22, 2023

Hmmm, it's been a month and no response yet. Looks like this is not what the author wants.

Oh I now see that the Qogir-kde has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants