Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185
Ok, this was quite an adventure. After lots of weird bugs, I'm at the point I can't find any more problems with it.
Example of old (incorrect) line height calculation, overlapping lines:
![image](https://user-images.githubusercontent.com/4075314/99706282-d5fc9e00-2a68-11eb-8a6b-6b24ea978a00.png)
Example of new line height calculation:
![image](https://user-images.githubusercontent.com/4075314/99706347-ec0a5e80-2a68-11eb-8bbf-8089f5da6e7e.png)
Once I add the leading control feature, the old to new format conversion script should be able to offset this so old files look the same (by setting a negative leading value).