Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Added fs-extra as a direct dependency of Blendid #553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented Apr 12, 2018

The fs-extra is required directly by Blendid in file gulpfile.js/tasks/replace-files.js. However, this dependency was expected to be present transitively via browser-sync.

Since it's a direct dependency of Blendid, it should be listed as such in the package.json. By not being present, it was causing us problem when using Yarn workspaces where fs-extra was not resolvable correctly (because it was in different node_modules folder).

Used version [email protected] to remain the same as browser-sync#fs-extra.

The fs-extra is required directly by Blendid in file
`gulpfile.js/tasks/replace-files.js`. However, this dependency was expected
to be present transitively via `browser-sync`.

Since it's a direct dependency of Blendid, it should be listed as such in
the `package.json`. By not being present, it was causing us problem when
using Yarn workspaces where `fs-extra` was not resolvable correctly (
because it was in different `node_modules` folder).

Used version `[email protected]` to remain the same as `browser-sync#fs-extra`.
@maoueh maoueh force-pushed the fix/fs-extra-dependency-missing branch from 1ab86bf to 56a83d0 Compare April 12, 2018 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant