Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking: Update benchmarks/performance #59

Closed
vickumar1981 opened this issue Oct 28, 2020 · 3 comments
Closed

Benchmarking: Update benchmarks/performance #59

vickumar1981 opened this issue Oct 28, 2020 · 3 comments
Milestone

Comments

@vickumar1981
Copy link
Owner

vickumar1981 commented Oct 28, 2020

This is very open-ended, but at a start, deciding upon a way to run benchmark tests would be a great improvement, and would allow code changes to be tested from the perspective of performance.

** To do **

  • Evaluate bench marking tools available
  • Decide upon bench marking approach
  • Implement benchmarks in test suite.
@vickumar1981 vickumar1981 added this to the 1.2.4 milestone Oct 28, 2020
@vickumar1981
Copy link
Owner Author

vickumar1981 commented Oct 30, 2020

Per PR: #61,

we'll be using the sbt-jmh plugin (https://github.com/ktoso/sbt-jmh) to run behcnmarks.

Currently, benchmarks can be run from the project root:

./sbt bench/jmh:run -i 1 -wi 1 -f1 -t1

TO DO:

  • Bump sbt-jmh plugin version to 0.4.0, Doesn't work. Stick with 0.3.7
  • Document usage of benchmarks
  • Decide whether to benchmark against another library like apache-commons-text (https://commons.apache.org/proper/commons-text/)
  • Decide whether to add more benchmarks for other classes besides ArrayDistance (maybe StringDistance, for example)

@vickumar1981 vickumar1981 changed the title Add benchmarking ~~Add benchmarking~~ Update benchmarks/performance Nov 1, 2020
@vickumar1981 vickumar1981 changed the title ~~Add benchmarking~~ Update benchmarks/performance Benchmarking: Update benchmarks/performance Nov 1, 2020
@vickumar1981
Copy link
Owner Author

Tested version 0.4.0 of the sbt-jmh plugin, and it doesn't look like it's working. Will stick with 0.3.7 for now.

@vickumar1981
Copy link
Owner Author

Closing this issue and creating some more granular ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant