Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Spinteractive #1

Closed
vheesen opened this issue Apr 20, 2018 · 3 comments
Closed

Improvements to Spinteractive #1

vheesen opened this issue Apr 20, 2018 · 3 comments
Assignees

Comments

@vheesen
Copy link
Owner

vheesen commented Apr 20, 2018

Following improvments to spinteractive are needed:

  • 'Information labels' ?
  • The values for reduced chi^2 are not correct. They are too low, particularly for the spectral index.
  • Set first_data_point_at_0_kpc = 1

With regards to the chi^2 discrepancy, I have put my own script to calculate reduced chi^2 into the folder 'spinteractive'. Just run 'python chi_NE.py' and it calculates the reduced chi^2 for both the first intensity (in this case LOFAR) and the spectral index. It assumes that the number of fit parameters n = 0, so that the degrees of freedom dof = N, where N is the number of data points. We might have to change n to depending on what we fit. For a constant advection speed it should be at least 2 or 3.

@amisk
Copy link
Collaborator

amisk commented Jul 4, 2018

Corrected reduced chi^2 calculation.

Added effective beam option.

@vheesen
Copy link
Owner Author

vheesen commented Jul 4, 2018

Super! Just add the other two frequencies as well when you have time ;-) For me the parameter search does also not yet work.

@amisk
Copy link
Collaborator

amisk commented Sep 12, 2018

fixed parameter search.

@vheesen vheesen closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants