-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting to mute a unanswered call makes it unmuteable after answer #685
Comments
In order to allow muting before connection is created we could add a check in _toggleMuteAudio(mute)
{
// RTCPeerConnection is not created yet, skipping.
if (!this._connection) {
return;
}
const senders = this._connection.getSenders().filter((sender) =>
{ But then everywhere we do |
I think we should just document that, for receiving invites, |
We're running JsSIP v3.6.1.
When
session.mute()
is called on an unanswered incoming call, the following error is thrown.I suppose that since the call is not answered yet, its RTCPeerConnection is
null
. However, the variableRTCSession#_audioMuted
is set totrue
regardless.After answering the call, we can attempt to mute it again by calling
session.mute()
. Since_audioMuted
is stilltrue
, nothing happens, and no tracks are disabled. The call is unmuteable at this point.There are pretty easy, somewhat hacky, ways to get around this - calling
RTCSession.unmute
first, checking for a connection, etc - but it seems somewhat buggy, so we thought an issue is appropriate :)The text was updated successfully, but these errors were encountered: