Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __source to JSX transformation for better DX #764

Closed
rauchg opened this issue Jan 14, 2017 · 4 comments
Closed

Add __source to JSX transformation for better DX #764

rauchg opened this issue Jan 14, 2017 · 4 comments
Assignees

Comments

@gaearon
Copy link

gaearon commented Jan 14, 2017

(Only in DEV) ;-)

@rauchg
Copy link
Member Author

rauchg commented Jan 14, 2017

#devmodegate

@arunoda
Copy link
Contributor

arunoda commented Jan 14, 2017

@rauchg how do we identify whether we are on the dev mode or not?
If we are doing to add this our babel preset, we need a way to pass that.

CRA is doing that with an NODE_ENV. Seems like we are not depending on NODE_ENV for the build time. I think we should set it while doing next build and next start.

If so, this is so eazy to do. Otherwise, we could add it directly to the webpack config.

@timneutkens
Copy link
Member

This is incredibly nice 😄

@timneutkens timneutkens added Status: Ready and removed good first issue Easy to fix issues, good for newcomers labels Feb 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants