Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not encourage sensitive credentials in repo #83

Open
mryellow opened this issue Jan 24, 2018 · 3 comments
Open

Should not encourage sensitive credentials in repo #83

mryellow opened this issue Jan 24, 2018 · 3 comments

Comments

@mryellow
Copy link

As with https://github.com/veox/python2-krakenex/issues/4 the committing of a sensitive file to source control is less than ideal. Instead private sensitive information should be kept out of repositories.

@veox
Copy link
Owner

veox commented Jan 25, 2018

From the other issue:

Would be better to provide a setup which uses dotenv or something similar and gitignores the local credential file. As it stands you're encouraging users to go with a layout which is less than best practice.

@veox
Copy link
Owner

veox commented Jan 25, 2018

Currently, the examples show load_key('file-in-same-dir.key'). This could be changed to something else (e.g. '/secure-store/kraken.key').

What would using dotenv provide? After all, this approach still needs a .gitignore. The current one has a line for *.key. Perhaps there should be a recommendation to copy this file to the project directory...

@mryellow
Copy link
Author

Perhaps there should be a recommendation

Not a bad idea.

In the past I've had setups where sensitive file is gitignore'd but leaving an example version like: kraken.example.key. Then you can put a real version right next to it and be assured it isn't committed.

@veox veox changed the title Encouraging sensitive credentials in repo Should not encourage sensitive credentials in repo May 25, 2018
@veox veox removed the help wanted label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants