-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to train data once there is some errors #299
Comments
Yes, we should add manual and automated (LLM-based) error correction |
I think simply passing the error message that is produced when attempting to extract the records to the LLM for a second iteration is a simple solution that should work (together with the rest of the context, current user question and previous sql query as well, of course). This can be done several times, if of interest, to iteratively converge to the right SQL query. The number of retries could be a parameter that is set through the config. @zainhoda I can make a PR for this, if the solution sounds sufficient :] |
Thanks for the offer @andreped! I actually have both of these (manual and automated correction) mostly completed in a local branch and it works quite well. I'm just adding a bunch of options to the built-in UI and I'll include it in the next release |
Beat me to it then 😅 That's great! Looking forward to testing it with the upcoming release! |
@zainhoda Are you able to make this release today? We wanted this feature included before upgrading our Vanna version :] |
@zainhoda Where do we allow generate_sql to retry if it fails by passing the error message? I fail to see where in the code this logic happens. I saw the PR mentioned above and I can see that there is some retry logic for the I am using |
@andreped you’re right — right now it’s in the flask app only. Do you have a proposal for where and how this would fit in the base package? |
Can we have a chance to set answer is wrong for training data once there are some errors in the answer.
The text was updated successfully, but these errors were encountered: