-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write report in case of success #117
Comments
As you may have noticed, I'm spending very little time on this repo. Haven't used it myself in years. The suggestion sounds good, but likely the only way for this to get implemented, is for you to do it yourself. Me or maybe @XhmikosR will review and land it eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there are not even notices found for the nested files, no report is written out. If the report is published on a server together with the build output, it will be there only, if validation failed. It makes the link to the validation report in the summary build report broken, although nothing went wrong :-)
The problem seems to be, that the reporter is not called at all, if there is nothing to report. Would it be possible to call it with the list of files without any problems found? For example:
There is a related issue with a partially failing validation. If you check ten files and only one ends up with warnings, the report will contain only this one file. The other nine files will not be shown as valid in the report.
How about introducing an option for enabling warning-free files in the report?
The text was updated successfully, but these errors were encountered: