-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having to restart Firefox in between each task #105
Comments
Hello:
If I delete Empty Folders... And then I want to do a
Dupe Search, I have to close/reopen before it will do so.
I tried, but this does not occur here.
It probably means that the deletion stucks somewhere, because
of some error: Only when the background process of deletion
finishes successfully, the buttons are re-enabled.
Can you find out the error with DOM inspector?
(I am afraid without an error message and being able to
reproduce the problem myself, I am unable to fix this error.)
If it is the same run in which you receive the timeout error,
no DOM inspection is necessary, as this error is then of course
the error cause I am looking for:
Error: transaction timeout
Normally (at least, in previous versions of firefox), firefox
should not just timeout and tacitly stop the script, but
open a window and ask you whether to stop the script (but
maybe you changed some configure option to open this window -
see below - or firefox behavior has changed it meanwhile).
If this window should open, you should press "no", of course,
while firefox is still in the process of bookmark deletion.
Deleting bookmarks just needs some time, and if firefox
thinks that this takes too long and stops the script, there
is nothing which the extension can do about - firefox just
stops the process, but as remarked above only finishing of
the process will re-enable the buttons for the Dupe Search.
If in your configuration or new versions of firefox this window
should not appear anymore, but just the script is stopped
without asking, I am afraid that there is nothing which the
extension can do to fix this problem. You may attempt to
increase the timeout before firefox stops a script:
Type "about:config" and search in the new window for "run_time".
In my case, there are three timeout values and one flag:
dom.max_chrome_script_run_time
dom.max_ext_content_script_run_time
dom.max_script_run_time
dom_max_script_run_time.require_critical_input
Maybe the latter flag is "false" for you is the configuration
option which makes the window not open for you?
Otherwise, try to increase the other 3 values (I am not sure
which one is responsible in this case).
The disadvantage of increasing the values is of course that
perhaps some evil scripts might have more time to run until
they are stopped, so it might worth to increase this values
only when you plan to run bookmark-dupes, but this is of
course up to you to decide.
The other thing you could do is to examine why firefox takes
so much time for you for deleting bookmarks that it runs into
the timeout in the first place:
Normally, several hundred bookmarks should be deleted in a
second. If you have other bookmark extensions installed or the
"edit bookmark window" open, this could slow down the process
of deletion considerably. I had also some (rare) reports from
cases where it turned out that the bookmark structure was
crippled internally.
Best Regards
Martin
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1- I'm finding I have to close Firefox and restart in order to do another task. If I delete Empty Folders... And then I want to do a Dupe Search, I have to close/reopen before it will do so.
2- For some reason the dupes checking will not include the main Bookmarks Menu. I had to make a temp folder on the Bookmarks Toolbar and move everything from the main Bookmarks Menu to this temp Toolbar folder in order for the add-on to "see them" It doesn't detect anything that exists in the Main Bookmarks Menu.
3- I also receive an error: " Error after removing 946 bookmarks. Error: transaction timeout, most likely caused by unresolved pending work.
** (This extension has been a lifesaver after a particular synchronization app duplicated my bookmarks in exponential numbers. There do, however seem to be a couple of glitches. I'll forward more detail to the developer... ) **
The text was updated successfully, but these errors were encountered: