Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In a V22 project, any view with a checkbox gets 'value="on"' added to the checkbox. #2432

Open
enver-haase opened this issue Mar 4, 2022 · 2 comments

Comments

@enver-haase
Copy link

Steps to reproduce

(Attach a reproducable project if possible)

See headline

Actual behavior

See headline

Expected behavior

I expect the attributes should not be changed

IDE, Designer and OS version

IDEA/latest macOS/latest

@enver-haase
Copy link
Author

<vaadin-checkbox id="cbOnCampus" style="align-self: flex-end;" label="view.preorder.onCampus" type="checkbox" value="on"></vaadin-checkbox>


Also, why is 'type' there???

Same applies to vaadin-text-field, also gets 'type' added.

@anssit
Copy link
Contributor

anssit commented Mar 9, 2022

Designer scans the properties of the web component and serializes all non-default values. type has no explicit default value, but checkbox sets it in its constructor. value is also set in the constructor.

As these values are not set by the user, it's reasonable to expect that Designer would not serialize them. However, this is the logic at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants