Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket transport support for v2ray #238

Merged
merged 48 commits into from
Aug 15, 2016
Merged

Conversation

xiaokangwang
Copy link
Contributor

Websocket transport implements a HTTP(S) compliable, surveillance proof transport method with plausible deniability.

This transport was disscussed at
#224
https://trello.com/c/3uCCeBkC/8-add-websocket-transport

@codecov-io
Copy link

codecov-io commented Aug 15, 2016

Current coverage is 87.70% (diff: 68.66%)

Merging #238 into master will decrease coverage by 0.53%

@@             master       #238   diff @@
==========================================
  Files           157        166     +9   
  Lines         14725      15151   +426   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          12993      13288   +295   
- Misses         1320       1428   +108   
- Partials        412        435    +23   

Powered by Codecov. Last update cc92973...2251935

type JsonConfig struct {
ConnectionReuse bool `json:"connectionReuse"`
Path string `json:"Path"`
Pto string `json:"Pto"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does PTO mean? Path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protocol .....

@xiaokangwang
Copy link
Contributor Author

Writing tests now.

@@ -69,12 +70,25 @@ func (wsl *WSListener) listenws(address v2net.Address, port v2net.Port) error {
errchan := make(chan error)

listenerfunc := func() error {
return http.ListenAndServe(address.String()+":"+strconv.Itoa(int(port.Value())), nil)
ol, err := net.Listen("tcp", address.String()+":"+strconv.Itoa(int(port.Value())))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ListenTCP here. It removes some unnecessary error checking in NewStoppableListener.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by 32e8deb

s := make(chan int)
go func() {
buf := make([]byte, 4)
conn.Read(buf)
Copy link
Collaborator

@v2ray v2ray Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify what is read. Same below.

@v2ray v2ray merged commit 667b71a into v2ray:master Aug 15, 2016
3gZ2jA pushed a commit to 3gZ2jA/v2ray-core that referenced this pull request Oct 8, 2020
* remove shadowsosks ota

* remove unused buf.Reader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants