Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient funds transaction succeeds #2

Open
ekkis opened this issue Feb 28, 2019 · 0 comments
Open

Insufficient funds transaction succeeds #2

ekkis opened this issue Feb 28, 2019 · 0 comments

Comments

@ekkis
Copy link

ekkis commented Feb 28, 2019

I recently issued a transaction attempting to send more funds than were available in my wallet, in order to see the transaction fail. it succeeded which puzzled me greatly. I asked about it here:

https://stackoverflow.com/questions/54918074/how-to-tell-if-an-erc20-token-transfer-succeeded/54923014#54923014

...and the answer came back that the transfer method should require() instead of returning false (please see Nikos' reply to the question)

I don't know enough Solidity to implement this or I would offer a PR but it should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant