Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide edit capabilites in code and assembly windows #603

Open
Cairn23 opened this issue Apr 4, 2018 · 4 comments
Open

Provide edit capabilites in code and assembly windows #603

Cairn23 opened this issue Apr 4, 2018 · 4 comments
Labels
enhancement This is a feature request gui The issue involves the GUI client

Comments

@Cairn23
Copy link

Cairn23 commented Apr 4, 2018

It would be good to have the ability to rename variables in the c code and assembly window once the de-compilation process has completed. This will then allow the user to make the generated assembly and code easier to read and maintain. IDA / Hex rays allows this in the assembly, but not on the generated code, this is because the generated C is not linked to the original binary, so if possible would provide a feature which is better than the market leader. Looking at the code I think the solution is to create a edit class writer object, similar to the function hyperlink and use this for any variable in the code.

@uxmal uxmal added enhancement This is a feature request gui The issue involves the GUI client labels Apr 4, 2018
@uxmal
Copy link
Owner

uxmal commented Apr 4, 2018

I agree. We currently support renaming procedures, but you need to select them in the project browser, not as you are expecting in the source window. Naturally the renaming capability should be applicable to global variables. Local variables should also be renamable; the difficulty lies in how to implement this given how Reko works internally.

@Cairn23
Copy link
Author

Cairn23 commented Apr 4, 2018 via email

@uxmal
Copy link
Owner

uxmal commented Apr 4, 2018

That sounds really interesting. Reko could benefit from signature identification support. Let me know when you're ready to integrate with Reko; I'd be glad to assist in any way I can.

@uxmal
Copy link
Owner

uxmal commented Apr 4, 2018

Also, be sure to check out https://gitter.im/uxmal/reko, the Reko chat room, it may be a good place for a design discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature request gui The issue involves the GUI client
Projects
None yet
Development

No branches or pull requests

2 participants