Feat: DB Proxy Adapter #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
commented
Oct 16, 2023
Meldiron
commented
Oct 16, 2023
Meldiron
commented
Oct 16, 2023
Meldiron
commented
Oct 16, 2023
abnegate
reviewed
Oct 19, 2023
Comment on lines
+5
to
+7
| use Utopia\Database\Exception; | ||
|
|
||
| class Conflict extends Exception |
There was a problem hiding this comment.
Let's make sure we check if there's anywhere we need to update the order of catch blocks because of this change (if any sub-types are caught, those catches need to now come before the DatabaseException catch)
tests/Database/Base.php
Outdated
| @@ -5088,7 +5088,7 @@ public function testOneToOneTwoWayRelationship(): void | |||
| ], | |||
| ]); | |||
|
|
|||
| static::getDatabase()->createDocument('country', $doc); | |||
| static::getDatabase()->createDocument('country', new Document($doc->getArrayCopy())); | |||
There was a problem hiding this comment.
because test is failing without it. Maybe now that its fully stateless, some problem came up
Meldiron
commented
Feb 22, 2024
Meldiron
commented
Feb 27, 2024
eldadfux
reviewed
Mar 1, 2024
eldadfux
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB proxy is dedicated HTTP server that maintains all database collections.
Using this proxy instead of separating maximum connection limit between containers allows improvements to scalability. It also prevents many idling connections when they could be used better by another containers.