Same twoWayKey #327
Closed
Same twoWayKey #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Oct 2, 2023
Co-authored-by: Jake Barnby <[email protected]>
abnegate
reviewed
Oct 13, 2023
Comment on lines
+1540
to
1549
| try { | ||
| if ($attribute->getAttribute('type') === self::VAR_RELATIONSHIP | ||
| && \strtolower($attribute->getAttribute('options')['twoWayKey']) === \strtolower($twoWayKey) | ||
| && $attribute->getAttribute('options')['relatedCollection'] === $relatedCollection->getId() | ||
| ) { | ||
| throw new DuplicateException('Related attribute already exists'); | ||
| } | ||
| } catch (DuplicateException $e) { | ||
| $twoWayKey ??= $collection->getId() . '_' . uniqid(); | ||
| } |
There was a problem hiding this comment.
I don't think we need a try/catch here, we can use use the if:
Suggested change
| try { | |
| if ($attribute->getAttribute('type') === self::VAR_RELATIONSHIP | |
| && \strtolower($attribute->getAttribute('options')['twoWayKey']) === \strtolower($twoWayKey) | |
| && $attribute->getAttribute('options')['relatedCollection'] === $relatedCollection->getId() | |
| ) { | |
| throw new DuplicateException('Related attribute already exists'); | |
| } | |
| } catch (DuplicateException $e) { | |
| $twoWayKey ??= $collection->getId() . '_' . uniqid(); | |
| } | |
| if ($attribute->getAttribute('type') === self::VAR_RELATIONSHIP | |
| && \strtolower($attribute->getAttribute('options')['twoWayKey']) === \strtolower($twoWayKey) | |
| && $attribute->getAttribute('options')['relatedCollection'] === $relatedCollection->getId() | |
| ) { | |
| $twoWayKey ??= $collection->getId() . '_' . uniqid(); | |
| } |
abnegate
reviewed
Oct 16, 2023
| throw new DuplicateException('Related attribute already exists'); | ||
| } | ||
| } catch (DuplicateException $e) { | ||
| $twoWayKey ??= $collection->getId() . '_' . uniqid(); |
There was a problem hiding this comment.
I think this should be $twoWayKey = $collection->getId() . '_' . uniqid();, otherwise it will only assign if null
|
We tool care of this on Appwrite side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.