Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Utopia\Database\Query::getByType() to not be variadic #191

Open
Tracked by #190
stnguyen90 opened this issue Sep 22, 2022 · 0 comments
Open
Tracked by #190

Update Utopia\Database\Query::getByType() to not be variadic #191

stnguyen90 opened this issue Sep 22, 2022 · 0 comments

Comments

@stnguyen90
Copy link
Contributor

stnguyen90 commented Sep 22, 2022

Variadic functions can be confusing. It's much clearer to use arrays instead:

-    public static function getByType(array $queries, string ...$types): array
+    public static function getByType(array $queries, array $types): array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant