Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.40 does not build on older kernels #2874

Open
satmandu opened this issue Mar 29, 2024 · 4 comments
Open

2.40 does not build on older kernels #2874

satmandu opened this issue Mar 29, 2024 · 4 comments

Comments

@satmandu
Copy link

The lsfd build fails due to missing kernel bfd headers, for instance, if kernel 3.8 headers are used.

Could a meson option to bypass the build of lsfd be added?

@satmandu
Copy link
Author

This was insufficient to fix this:

      diff -Npaur a/meson.build b/meson.build
      --- a/meson.build	2024-03-28 23:37:49.623330230 -0400
      +++ b/meson.build	2024-03-28 23:39:08.982615866 -0400
      @@ -2703,6 +2703,7 @@ endif
       mq_libs = []
       mq_libs += cc.find_library('rt', required : true)

      +opt = not get_option('build-lsfd').disabled()
       exe = executable(
         'lsfd',
         lsfd_sources,
      @@ -2712,7 +2713,7 @@ exe = executable(
         dependencies : mq_libs,
         install_dir : usrbin_exec_dir,
         install : true)
      -if not is_disabler(exe)
      +if opt and not is_disabler(exe)
         exes += exe
         manadocs += ['misc-utils/lsfd.1.adoc']
       endif
      diff -Npaur a/meson_options.txt b/meson_options.txt
      --- a/meson_options.txt	2024-03-28 23:39:28.782438124 -0400
      +++ b/meson_options.txt	2024-03-28 23:40:38.789810977 -0400
      @@ -53,6 +53,8 @@ option('build-fdisks', type : 'feature',
              description : 'build fdisk(8), sfdisk(8) and cfdisk(8)')
       option('build-mount', type : 'feature',
              description : 'build mount(8) and umount(8)')
      +option('build-lsfd', type : 'feature',
      +       description : 'build lsfd')
       option('build-losetup', type : 'feature',
              description : 'build losetup')
       option('build-zramctl', type : 'feature',

@jwillikers
Copy link
Contributor

The lsfd dependency also pulls in lib rt as a required dependency, which prevents building libuuid on macOS.

@jwillikers
Copy link
Contributor

@satmandu Can you try with #2879?

@satmandu
Copy link
Author

@satmandu Can you try with #2879?

That lets me fix the build. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants