Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow cors for grpc gateway handler #3574

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: allow cors for grpc gateway handler #3574

merged 1 commit into from
Jun 21, 2024

Conversation

RyoJerryYu
Copy link
Contributor

Add CORS allow all for gRPC-gateway handler. Trying to fix #3573 .

@RyoJerryYu RyoJerryYu requested a review from boojack as a code owner June 14, 2024 16:06
@quanru quanru mentioned this pull request Jun 17, 2024
Merged
boojack
boojack approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack changed the title fix #3573: allow cors for grpc gateway handler fix: allow cors for grpc gateway handler Jun 21, 2024
@boojack boojack merged commit a09c669 into usememos:main Jun 21, 2024
2 checks passed
@RyoJerryYu RyoJerryYu deleted the feat-add-cors-for-grpc-gateway branch June 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/api/v1/memos support cors
2 participants
@RyoJerryYu @boojack