Unable to add urls with complex query string

[davidolrik]

If I try to shorten any url with a query string I get the following error: The url format is invalid.

[optiroot]

Thank you for opening this issue!
Mmh... I can't replicate this.
Validation errors were solved in the commit Updated Regex to allow ?, _ - and =
Maybe you need to update UrlHum from the repo?

[davidolrik]

I'm running on latest, and fixed it by removeing the trailing $ from this rule in app/Http/Requests/ShortUrl.php

- 'url' => 'required|max:500|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\_\-\?\=\/\w \.-]*)*\/?$/',
+ 'url' => 'required|max:500|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\_\-\?\=\/\w \.-]*)*\/?/',

[davidolrik]

You should allow pretty much any character in the query string, stuff like | and & are definitely missing.

A better approach would be to use filter_var($url, FILTER_VALIDATE_URL) which validates the url according to rfc2396.

[optiroot]

With my push GitHub automatically closed the issue, sorry.

In the end I decided to use default Laravel url validation, which uses FILTER_VALIDATE_URL anyway!
Thank you for your issue. It was very helpful.
Going to close this again 😄