[Bug] QR Code is showing wrong url on scan

[erdmenchen]

Describe the bug
When trying to scan a QR code of a shortened url, it points to e.g. https://localhost/1 and not the real shortened url.

To Reproduce
Just try to open any generated QR code with current state of main branch.

Expected behavior
QR code should point to the shortened url.

Additional context
Bug is in App\Http\Controllers\QRCodeController, it uses the wrong parameter for $url:

$qrCode = QrCode::format($format)->size(300)->generate(route('click', $url));

should be

$qrCode = QrCode::format($format)->size(300)->generate(route('click', $url->short_url));

Source:

UrlHum/app/Http/Controllers/QRCodeController.php

Line 68 in 5d0dead

$qrCode = QrCode::format($format)->size(300)->generate(route('click', $url));

[erdmenchen]

Same in Admin UI in QR-Code modal:

UrlHum/resources/views/url/partials/qrcodemodal.blade.php

Line 12 in 5d0dead

<img class="w-100" src="{{ route('qrcode.svg', $url) }}">

EDIT:
It should be changed here, because the modal is also called from within the analytics page with only the short-url, not the whole url-object:

UrlHum/resources/views/url/edit.blade.php

Line 122 in 5d0dead

@include('url.partials.qrcodemodal', ['url' => $data['url']])

Should be:

@include('url.partials.qrcodemodal', ['url' => $data['url']->short_url])

[optiroot]

Thank you so much for your help.

Fix implemented in next commit.