Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request instead of $request #1

Closed
thsteinmetz opened this issue Apr 30, 2019 · 2 comments
Closed

request instead of $request #1

thsteinmetz opened this issue Apr 30, 2019 · 2 comments
Assignees
Labels
waiting opinions To go on we wait for community opinions on the issue

Comments

@thsteinmetz
Copy link

$siteUrl = request()->getHttpHost();

@optiroot
Copy link
Member

Thank your for opening the issue!
Here we are getting the url of the "server" website, so I thought that for more clearness would have been better to not to use the variable $request as it is injected for the real request and so to use the global helper.

If you know a better reason to edit that line of code I am willing to update it without problems!
Meanwhile I wait for other opinions too!

@optiroot optiroot added the waiting opinions To go on we wait for community opinions on the issue label Apr 30, 2019
@optiroot optiroot self-assigned this Apr 30, 2019
@thsteinmetz
Copy link
Author

Ah, understood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting opinions To go on we wait for community opinions on the issue
Projects
None yet
Development

No branches or pull requests

2 participants