Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support async endpoints #28

Closed
3 tasks done
unmade opened this issue Aug 24, 2021 · 0 comments · Fixed by #29
Closed
3 tasks done

Support async endpoints #28

unmade opened this issue Aug 24, 2021 · 0 comments · Fixed by #29
Labels
enhancement Improvement of the existing functionality
Milestone
MVP

Comments

@unmade
Copy link
Owner

unmade commented Aug 24, 2021 •
edited
Loading

Refactor endpoints according to the changes made in unmade/shelf-back#24:

  • always move file with /files/move_batch or /files/move_to_trash_batch
  • empty trash asynchronously
  • delete file asynchronously

For deleting a file and emptying the trash we can use optimistic update and hide files even before task completes
@unmade unmade added the enhancement Improvement of the existing functionality label Aug 24, 2021
@unmade unmade added this to the MVP milestone Aug 24, 2021
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Support deleteImmediatelyBatch action (#28)
86c3779
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Always use batch methods on files (#28)
147ff85
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Indicate in the status bar that trash is emptying (#28)
9364491
@unmade unmade mentioned this issue Aug 24, 2021
Merged
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Support deleteImmediatelyBatch action (#28)
a446632
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Always use batch methods on files (#28)
5640a81
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Indicate in the status bar that trash is emptying (#28)
0a3ebb7
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Indicate in the status bar that trash is emptying (#28)
23b7c95
unmade added a commit that referenced this issue Aug 24, 2021
@unmade
Indicate in the status bar that trash is emptying (#28)
3645500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of the existing functionality
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Resolve #28: file async actions unmade/shelf-front
1 participant
@unmade