Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image blocks always set width to 500px and do not honor "full-width=false" setting #16

Open
ronvenna opened this issue May 9, 2018 · 2 comments

Comments

@ronvenna
Copy link

ronvenna commented May 9, 2018

This makes all the images appear stretched and low-resolution.

@jsahani
Copy link

jsahani commented Jun 12, 2018

Having the same issue which is causing so much problem as we have to go live with our webapp, Also i have emailed regarding the same.

I found the issue with “full-width” property

I have changed the “Displaymode” to web and now “image” block shows “Width Slider” instead of “Full Width” Toggle.

But still there is issue with “Row Background” as even in “Displaymode:web” It has “Full-width” option which is still creating the same issue that on re-editing “Row Background” image is getting messed up and “Image” Block which has “Width Slider” is showing fine now.

Please confirm as this is something from your end to fix.

— Showing fine here while creating the template.
Screenshot :- https://www.dropbox.com/s/a1aumnp38cfdz4p/Screenshot%202018-06-11%2016.48.07.png?dl=0

— Showing fine inside our webapp after saving.
Screenshot :- https://www.dropbox.com/s/p18noc1j1prz1pb/Screenshot%202018-06-11%2016.49.33.png?dl=0

— This is where the issue come up. While re-editing.
Screenshot :- https://www.dropbox.com/s/mvro2g69c609g1d/Screenshot%202018-06-11%2016.50.52.png?dl=0
Note:- As you can see that “FullWidth” is now automatically active. Tho “Image” Block images are showing fine as they don’t have “FullWidth” option in “displaymode:web”.

I hope you can understand this, If not then please let me know so that I can explain my self differently.

Also I wanna know is it possible to add our own file manager to pick images from there which user already uploaded to make stop duplicate images while uploading.

And in the "displaymode:email" this is what is happening.

Before saving on editor :- https://www.dropbox.com/s/k1dhjogvb1oepek/Screenshot%202018-06-11%2003.09.45.png?dl=0
Screenshot of CKeditor inside webapp:- https://www.dropbox.com/s/mkxz9dki92d07oh/Screenshot%202018-06-11%2003.04.55.png?dl=0

Now when I as a user try to re-edit this template by opening up the editor again, its making all the images full-width automatically, and messing up the template.

Screenshot Called for Re-Editing on editor :- https://www.dropbox.com/s/9423gjxmj9uais6/Screenshot%202018-06-11%2003.06.39.png?dl=0

I tired two different templates, and the same things happening on both. Layout is getting messed up when called for re-editing.

Thanks
Jatin

@andreas-globi
Copy link

I've been hitting my head on a wall most of the day with the same issue.

Make sure you're not ajaxing your design json as json as part of form data because everything will be converted to strings. (eg true becomes "true", 1 becomes "1", etc).

If you're sending as form data, rather send it as text, eg: JSON.stringify(design).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants