Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%2B is being normalized to + #34

Open
pi0 opened this issue Aug 17, 2021 · 2 comments
Open

%2B is being normalized to + #34

pi0 opened this issue Aug 17, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@pi0
Copy link
Member

pi0 commented Aug 17, 2021

Reported by @Kolobok12309 (#31 (comment))

Current behavior:

normalizeURL('/test%2Bfile.txt') = '/test+file.txt'

Expected behavior:

normalizeURL('/test%2Bfile.txt') = '/test%2Bfile.txt'
@pi0 pi0 closed this as completed in 500885b Aug 17, 2021
@pi0
Copy link
Member Author

pi0 commented Aug 17, 2021

fixed in 0.7.9

@dmitrykornilov
Copy link

dmitrykornilov commented Sep 24, 2021

So, according to RFC3986 I think that we have some unexpected behavior for now, because plus char is reserved as delimiter.

Current:

normalizeURL('/another+test%2Bfile.txt') = '/another%2Btest%2Bfile.txt'

Expected:

normalizeURL('/another+test%2Bfile.txt') = '/another+test%2Bfile.txt'

@pi0 pi0 reopened this Sep 24, 2021
@nozomuikuta nozomuikuta added the bug Something isn't working label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants