Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potetial to improve perf #70

Open
pi0 opened this issue Jan 10, 2024 · 0 comments
Open

Potetial to improve perf #70

pi0 opened this issue Jan 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Jan 10, 2024

Currently we use a dynamic array as the buffer for splitter core (https://github.com/unjs/scule/blob/main/src/index.ts#L30). Since we know about the (maximum) string length, we could instead make an array with known length and assign chars too.

Howevewr this needs some benchmark script to verify, just made issue to not forget! (PR welcome for bench > try)

@pi0 pi0 added the enhancement New feature or request label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant