-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer web
over node
export condition for non-node targets
#1123
Labels
Comments
Next.js seems using
Also related wintercg/runtime-keys#5 |
This was referenced Jun 6, 2023
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When resolving dependencies (both bundled and externalized), we also add a
node
export condition (like this).Doing this, basically breaks dual build for packages like
uncrypto
because they assume node is for Node.js only but it is also necessary to usenode
condition always because (sadly) many libraries in npm ecosystem still considernode ==== server
. We need to be cautious how to approach this but also eventually push the ecosystem and common libs to use a better conditionExample for vue-router conditions:
The text was updated successfully, but these errors were encountered: