Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update todo #5088

Closed
aryairani opened this issue Jun 12, 2024 · 7 comments · Fixed by #5177
Closed

update todo #5088

aryairani opened this issue Jun 12, 2024 · 7 comments · Fixed by #5177
Assignees

Comments

@aryairani
Copy link
Contributor

The updated command should

  • list name conflicts
  • list missing dependency names
    • bonus: provide hints if they are named in other project branches
  • list violated merge preconditions
  • list dependents of todo
@mitchellwrosen
Copy link
Member

mitchellwrosen commented Jun 12, 2024

What's "list dependents of todo" – typo?

@hojberg
Copy link
Member

hojberg commented Jun 14, 2024

@mitchellwrosen
Copy link
Member

Ah, yes, of course

@aryairani
Copy link
Contributor Author

aryairani commented Jun 24, 2024

Re:

  • bonus: provide hints if they are named in other project branches

Not sure what we can reasonably accomplish here, but this is the motivation:

image

@aryairani
Copy link
Contributor Author

aryairani commented Jun 24, 2024

Also, in the previous screenshot... what is ucm doing? It seems like if #dc5 appears in the list, that #t7r should too. But where's the dependent of #dc5? I guess I can use dependents to find out, but it would be better if todo told me why things were in the list.

image

@mitchellwrosen
Copy link
Member

@aryairani It's currently just showing the unnamed things that are directly – not indirectly – referenced by your code

@aryairani
Copy link
Contributor Author

aryairani commented Jun 24, 2024

@aryairani It's currently just showing the unnamed things that are directly – not indirectly – referenced by your code

Right, ok. We should consider at some point what other hints we could try to provide that would be helpful in choosing a name for it. Maybe that's dependent names, maybe it's names from other projects or Share, maybe it's something else.

And maybe transitive unnamed deps of from the direct unnamed deps, so that you're not getting one entry per time you todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants