Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete.term can be slow - maybe after it says Done? #5079

Open
ceedubs opened this issue Jun 12, 2024 · 1 comment
Open

delete.term can be slow - maybe after it says Done? #5079

ceedubs opened this issue Jun 12, 2024 · 1 comment
Labels

Comments

@ceedubs
Copy link
Contributor

ceedubs commented Jun 12, 2024

Describe and demonstrate the bug

Here I'm deleting an unused term on a branch that is close to the main branch of nimbus.

@cloud/nimbus/cleanup-2> delete.term services.fetchBlobFromFilesystem
updateRoot: 76.6 ms (cpu), 62.9 ms (system)
 
  Done.

InputPattern: 24.6 s (cpu), 11.9 s (system)

As you can see from the output the InputPattern timing is pretty slow; it feels like a long time to wait.

The output also shows that updateRoot is relatively fast. So there's a question of where the slowness is coming in. Perhaps in a dependency check to make sure that nothing is calling it? But dependents doesn't seem to be this slow.

Environment (please complete the following information):

  • ucm built from commit 335512e
  • OS/Architecture: NixOS 23.11 (Tapir); x86; 32 GB RAM; 16 cores
  • Browser, if applicable: N/A
@ceedubs ceedubs added the bug label Jun 12, 2024
@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 12, 2024

Notably delete.namespace is significantly faster. Though it is also known to have a bug in which it can lead to unnamed dependencies, so maybe it's taking a shortcut that it shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant