Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation: Add check to detect if a class is removed #87

Open
pederhan opened this issue Jun 17, 2024 · 0 comments
Open

Code generation: Add check to detect if a class is removed #87

pederhan opened this issue Jun 17, 2024 · 0 comments

Comments

@pederhan
Copy link
Member

pederhan commented Jun 17, 2024

When generating code, we don't want to remove any classes, as we want to support more versions than just the most recent one. For example, if Harbor removes support for the Robots V1 API in some new version, we still want to support it for users who are using older versions of Harbor.

Solutions

We can go one of two ways in my mind: Manual or automatic

Manual

The detection needs to find out which classes were removed, if any, and tell the user to add the class definition to the fragments directory so it is added to the final generated file.

Automatic

The code generator finds classes that were removed and automatically creates a fragment containing that class definition. This could be somewhat difficult to implement. We probably need to do it as some separate step prior to running parser.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant