Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] fast refresh #34

Open
twlite opened this issue Dec 7, 2023 · 4 comments
Open

[cli] fast refresh #34

twlite opened this issue Dec 7, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@twlite
Copy link
Collaborator

twlite commented Dec 7, 2023

Allow reloading the changes without restarting the bot when possible

@twlite
Copy link
Collaborator Author

twlite commented Dec 7, 2023

How to make this happen?

  • we keep track of what files are modified, if files inside validations/commands/events are changed, we can simply invoke reload method of commandkit
  • if main file is changed, we definitely need to restart the process from scratch
  • if any of the files imported by main file gets updated, we need to trigger restart (need to keep track of imports for this somehow)

@notunderctrl notunderctrl added the enhancement New feature or request label Dec 7, 2023
@twlite
Copy link
Collaborator Author

twlite commented Dec 7, 2023

@twlite twlite mentioned this issue Dec 7, 2023
@NotM1Dev
Copy link
Contributor

@twlite
Copy link
Collaborator Author

twlite commented Jan 25, 2024

We need to preserve client's connection while reloading the project. Simple fs-watch won't be enough for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants