Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of @actions/core #170

Open
meesvandongen opened this issue Mar 4, 2024 · 2 comments
Open

remove usage of @actions/core #170

meesvandongen opened this issue Mar 4, 2024 · 2 comments

Comments

@meesvandongen
Copy link
Contributor

In my previous issue I suggested changing the documentation to reflect the environment variables, but after some testing it seems that the environment variables are not set. Moreover, setting the environment variables is not possible from a child process (nodeJS) as far as I am aware.

For that problem specifically, I would suggest moving to files; e.g. changesets-gitlab-output.json

{
  "published": true,
  "publishedPackages": [
    { "name": "@xx/xx", "version": "1.2.0" },
    { "name": "@xx/xy", "version": "0.8.9" }
  ]
}

Then, a suggestion could be added to add the file to .gitignore.

More generally, @actions packages should not be used at all in this repo since it is only meant for Github actions.

If you are fine with such changes I can look into making a PR.

@JounQin
Copy link
Member

JounQin commented Mar 4, 2024

Thanks @meesvandongen , actually I've never used the output feature previously.

I'm fine to migrate environment variables into ~/changesets-gitlab.output.json for example.

So, PR welcome!

@meesvandongen
Copy link
Contributor Author

I have created a minimal change on #171, but haven't tested it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants